saecki / mp4ameta

A library for reading and writing iTunes style MPEG-4 audio metadata
Apache License 2.0
35 stars 5 forks source link

Sample rate: Use u32 instead of usize #16

Closed uklotzde closed 3 years ago

uklotzde commented 3 years ago

The type of the sample rate depends on the range of possible values, but neither on the platform nor the CPU architecture. The return type usize for SampleRate::hz() is not a good match. Using u32 with a known size would be a better choice.

saecki commented 3 years ago

Seems reasonable.

saecki commented 3 years ago

Done