search

saeedalipoor / icono

One tag One icon, no font or svg, Pure CSS
http://git.io/icono
MIT License
4k stars 301 forks source link

Use "extend placeholders" to remove internal class names from exposure #53

Closed jkjustjoshing closed 6 years ago

jkjustjoshing commented 6 years ago

The classes .icono-stroke, .stickCenterV, .stickCenterH, and .stickCenter are being exposed unnecessarily. This PR removes them from the Stylus and SCSS outputs by using extend placeholder classes.

LESS does not have a concept of "placeholder classes", so these classes are still part of the LESS output.

jkjustjoshing commented 6 years ago

I wasn't sure if I should include an update to ./dist/icono.min.css in the PR - let me know if I should and I can add one.

saeedalipoor commented 6 years ago

Thanks, @jkjustjoshing Please make dist folder update too.

jkjustjoshing commented 6 years ago

@saeedalipoor /dist folder has been updated!