search

saeeddhqan / Maryam

Maryam: Open-source Intelligence(OSINT) Framework
GNU General Public License v3.0
999 stars 166 forks source link

[Bug] Issue when creating report in xml format #90

Closed bushra2001 closed 3 years ago

bushra2001 commented 3 years ago

I would like to fix the following issue.

https://user-images.githubusercontent.com/61081924/111920145-3818ee80-8aaf-11eb-8014-4c68d07d9108.mp4

saeeddhqan commented 3 years ago

@bushra2001 do you want to be part of the contributors?

bushra2001 commented 3 years ago

Yes, I want to contribute to this project.

saeeddhqan commented 3 years ago

owasp-maryam this is the slack channel. join us, read the ideas and previous messages to get acquainted with the procedure.

z3y50n commented 3 years ago

I would like to fix the following issue. video_gsoc.mp4

The video seems broken. Could you either reupload it or explain the issue a bit more?

bushra2001 commented 3 years ago

I would like to fix the following issue. video_gsoc.mp4

The video seems broken. Could you either reupload it or explain the issue a bit more?

Try to watch video with full screen. I am trying to convert the video into gif. Issue: When I am trying to generate the report in xml format, it is showing me error.

bushra2001 commented 3 years ago

owasp-maryam this is the slack channel. join us, read the ideas and previous messages to get acquainted with the procedure.

I am unable to find slack channel, can you send me an invite? If you approve, should I start working on this issue?

z3y50n commented 3 years ago

I have sent you an invitation to your email

saeeddhqan commented 3 years ago

Do it with the dns_search output and let me know.

bushra2001 commented 3 years ago

Do it with the dns_search output and let me know.

Dns_search is not displaying an error because it is dictionary within dictionary. Only those modules, which are single dictionary are displaying errors. I have resolved this bug, working on pr.

saeeddhqan commented 3 years ago

It's totally not a bug. the input should have a key. You can fix it with a by-default key. Beware any change can make lots of problems in the output functions. Therefore, test the changes as far as you can. Thank you

bushra2001 commented 3 years ago

The output is coming as follows. I have test the changes with the following commands;

report xml dns_search osint/dns_search example.com report xml docs osint/email_search microsoft.com report xml wapps footprint/wapps owasp.org report xml entry_points footprint/entry_points example.com report xml social_nets osint/social_nets @owasp report xml suggestion osint/suggest amazon report xml crawl_pages footprint/crawl_pages owasp.org report xml onion_search osint/onion_search amazon

Is it fine, any suggestions will be appreciated. If you approve then I will create a pr.

xml-fixed

saeeddhqan commented 3 years ago

Make a PR.

saeeddhqan commented 3 years ago

Fixed by #97