saeedmaghdam / ZiraLink.Api

Expose Your Local Applications to the World
Other
2 stars 0 forks source link

Spike: refactor the code #2

Open saeedmaghdam opened 1 year ago

YAS-SIIN commented 1 year ago

I did something in feature/organizingproject branch

YAS-SIIN commented 1 year ago

We need to refactor the architecture of project. In my perspective, the DDD architecture with MediatR is a good solution.

YAS-SIIN commented 1 year ago

Also, on the service side, we need to use ViewModel instead of argument parameter.

YAS-SIIN commented 1 year ago

Also, we need to use Fluent Validation to check input data.

saeedmaghdam commented 1 year ago

We need to refactor the architecture of project. In my perspective, the DDD architecture with MediatR is a good solution.

It could make the project(s) potentially difficult to develop and maintenance, might be better to not make it more difficult.

saeedmaghdam commented 1 year ago

Also, on the service side, we need to use ViewModel instead of argument parameter.

What does it mean? could you give an example to make it more clear?

saeedmaghdam commented 1 year ago

Also, we need to use Fluent Validation to check input data.

Could you come up with a proposal?

YAS-SIIN commented 1 year ago

Also, we need to use Fluent Validation to check input data.

Could you come up with a proposal?

Yes, Sure.

YAS-SIIN commented 1 year ago

Also, on the service side, we need to use ViewModel instead of argument parameter.

What does it mean? could you give an example to make it more clear?

Also, on the service side, we need to use ViewModel instead of argument parameter.

What does it mean? could you give an example to make it more clear? I mean inside ProjectService class we can use ViewModel instead of parameters in every method.

saeedmaghdam commented 1 year ago

Also, on the service side, we need to use ViewModel instead of argument parameter.

What does it mean? could you give an example to make it more clear?

Also, on the service side, we need to use ViewModel instead of argument parameter.

What does it mean? could you give an example to make it more clear? I mean inside ProjectService class we can use ViewModel instead of parameters in every method.

It does not sound good to use any kind of DTOs for services, dto would make more value if it is used in APIs than it is used in services.