search

saeidamiri1 / rbox

https://github.com/saeidamiri1/rbox/wiki
MIT License
22 stars 3 forks source link

Key Binding Conflict with Select Word #7

Open bretonics opened 6 years ago

bretonics commented 6 years ago

There is a keybinding conflict with Ctrl-Shift-W with word selection in Atom's core atom-text-editor selector.

I think the key bindings rbox uses are way too broad:

'atom-text-editor:not([mini])':
  'ctrl-shift-W': 'hydrogen:add-watch'
'.platform-darwin, .atom-workspace':
  'ctrl-shift-W': 'hydrogen:add-watch'
'.platform-darwin, .atom-text-editor':
  'ctrl-shift-W': 'hydrogen:add-watch'

So broad in fact that custom keybindings, even when setting unset!, do not resolve the conflict. 

'atom-text-editor:not([mini])':
  'ctrl-shift-W': 'unset!'

'.platform-darwin, atom-text-editor':
  'ctrl-shift-W': 'unset!'

Why? Because if these are unset!, to remove rbox's bindings, they also actually unset the core Ctrl-Shift-W keybinding. I tried multiple combinations and it wouldn't work; either all are unset and nothing works, or leaving the atom-text-editor selector set activate rbox's keybinding, overriding the core atom-text-editor selector. Maybe I am mistaken, so any suggestions?

The only option was uninstalling/deleting rbox, and restarting Atom. Core key binding worked. So for now, this will be the case for me. Unless there is a different way to use the custom keybinding and I am mistaken somewhere.

saeidamiri1 commented 6 years ago

Now use ctrl-alt-w, https://github.com/saeidamiri1/rbox/wiki/Use-under-macOS.