search

saem / vscode-nim

Other
177 stars 23 forks source link

Initial integration of nimls #81

Closed yyoncho closed 2 years ago

yyoncho commented 2 years ago

Check https://github.com/nim-lang/langserver/pull/3

yyoncho commented 2 years ago

@saem

Got it, can we restrict it so it only looks at that module, node modules is huge

vsce does that by default. It does not pick dev deps.

You can register a listener, it'll listen to the the command, just guard it on the config

What do you mean by guarding it?

saem commented 2 years ago

You can register a listener, it'll listen to the the command, just guard it on the config

What do you mean by guarding it?

If check to ensure the backend is epc vs not.

yyoncho commented 2 years ago

You can register a listener, it'll listen to the the command, just guard it on the config

What do you mean by guarding it?

If check to ensure the backend is epc vs not.

There is no need for that, this guarding is performed by VScode itself. The epc won't register code action provider at all.

saem commented 2 years ago

My point is that the behavior should be uniform. So one can restart nimsuggest in either case (epc or nimls), that way there isn't a bifurcated experience.

yyoncho commented 2 years ago

IMHO having a bifurcated experience is inevitable given the fact that more and more functionality that won't be present in bare nimsuggest integration will be added to nimls. I can investigate how to make the command work for both - my concern is that this will be a wasted effort.

yyoncho commented 2 years ago

Force pushed.

yyoncho commented 2 years ago

ping

saem commented 2 years ago

Had read through, last bit is register a restart command for nimsuggest so that it's uniform.

yyoncho commented 2 years ago

Ok, I will try to implement it, although it looks like it will do more harm than good.

yyoncho commented 2 years ago

Added restart command for nimsuggest. Also, I changed a bit the wording in the readme to make it a bit more evident that one should expect a different set of functionality from lsp and nimsuggest modes in addition to the difference in how both behave.

saem commented 2 years ago

Sorry, for some reason I didn't see the notification for GitHub. Awesome, thanks.

yyoncho commented 2 years ago

Sorry, for some reason I didn't see the notification for GitHub. Awesome, thanks.

Thank you! Can you do a release?

yyoncho commented 2 years ago

Sorry, for some reason I didn't see the notification for GitHub. Awesome, thanks.

Thank you! Can you do a release?

Any update?

saem commented 2 years ago

https://github.com/saem/vscode-nim/commit/17070382e277188cf0a64f9fdcee3b6d28bdc501