saem / vscode-nim

Other
177 stars 23 forks source link

(reopen) change highlighting of static to match block, if #90

Closed morganholly closed 2 years ago

morganholly commented 2 years ago

see #86

saem commented 2 years ago

@morganholly looks like you've had quite the adventure. The revert via a revert commit isn't what I meant but a history rewrite to drop the commit.

Looks like a all the commits aren't actually material as some of them are likely in main. This article will walk you through interactive rebase and how to remove unnecessary commits: https://hackernoon.com/beginners-guide-to-interactive-rebasing-346a3f9c3a6d

Then if there is an issue with conflicts that's ok, I'll guide you through that with some instructions.

morganholly commented 2 years ago

for a change this small, maybe it would be better to make a new branch from the repo as it is currently bringing in the changes in a new commit

morganholly commented 2 years ago

ok i created #91