search

saeraa / mellankalix

Biograf för Mellankalix
2 stars 3 forks source link

24 4 indexhtml sökfunktion #62

Closed JonathanHolmgren closed 1 year ago

JonathanHolmgren commented 1 year ago

Har gjort en funktion där man kan söka på de olika filmerna. När du klickar på filmen så ska du ta dig till filmen sida med mer information.

https://share.vidyard.com/watch/fUSD6WvYJNMaWmsEVCrtQf?

Arash-SJPI22 commented 1 year ago

the js/searchOnPage.js is empty and dosen't seam to be doing anything? If not, remove it.

Arash-SJPI22 commented 1 year ago

I see that you use document.getElementsById/ByClassName, its best practice to use document.querySelector() # for id and . for class instead.

Arash-SJPI22 commented 1 year ago

If you enter some numbers or words that has no search result and press the search-button, the search bar is hidden but the gray search box is still visible.

You have created a very stylish search function, I really like it :D