saeyslab / CytoNorm

R library to normalize cytometry data
33 stars 6 forks source link

Add support for flowSets in CytoNorm #33

Closed DillonHammill closed 2 years ago

DillonHammill commented 2 years ago

Hi @SofieVG,

I have made some changes to the CytoNorm code base to add support for it within CytoExploreR.

Here is a summary of the changes:

I have run all examples and tested the code on flowSets and everything behaves as it should.

Please let me know if there are any additional modifications you would like me to make.

Cheers, Dillon

SofieVG commented 1 year ago

Hi Dillon,

I made a small adaptation to only return a flowSet from Cytonorm.normalize when a flowSet was given as input. When normalizing a set of files from directory, they are not always guaranteed to have the same columns (some might have additional columns not used for the normalization), which gives an error when converting to a flowSet at the end. Can you check whether it still works as expected for you with this change?