saeyslab / CytoNorm

R library to normalize cytometry data
33 stars 6 forks source link

Code proposal #8

Open SamGG opened 4 years ago

SamGG commented 4 years ago

Hi Sofie,

Does the gsub mean basename? At https://github.com/saeyslab/CytoNorm/blob/e94732cec4ce26c44d167c530978b2c5b296e55c/R/QuantileNorm.R#L494-L495

I think it you would interesting to store the untransformed along with the transformed channels. This redundant with the quantile plot but this will allow the user to see the transform with a classical flow software. I mean something like copying original expression of the transformed channels, renaming the colnames, and fr_append_cols them before wirting.

By the way, as the current process replaces the expression but do not alter the range, I wonder if there could be a problem if the transformed maximum is higher than the previous as the range does not change. This might be linked to previous issues.

Best