search

saeyslab / napari-sparrow

Other
17 stars 0 forks source link

Geometries when expanding don't save properly #187

Closed lopollar closed 4 months ago

lopollar commented 4 months ago

When exapning cells, and only performing this step, the shapes layer isn't saved properly. When reopening the object, the expanded shapes layer just looks like the original one.

Probably because we just adapt the geometry parameter on disk, but never write it

ArneDefauw commented 4 months ago

This is only when you use sp.sh.create_voronoi_boundaries(...)?

I see what is going on there, we do not write the results to disk.

I will fix this, but due to this https://github.com/saeyslab/napari-sparrow/issues/114, I think a better approach for expanding cells is to use:

sp.im.expand_labels_layer(...)

lopollar commented 4 months ago

Yes, I now use it to expand my veins, soI would just for this have to create a labels layer, which seems unnecesary

ArneDefauw commented 4 months ago

should be fixed on main by https://github.com/saeyslab/napari-sparrow/pull/188