saeyslab / nichenetr

NicheNet: predict active ligand-target links between interacting cells
452 stars 113 forks source link

`get_expressed_genes` - fix for Seurat v5 and add method for matrices #250

Closed csangara closed 5 months ago

csangara commented 5 months ago

This slightly differs from #247 in that this is no longer true:

The S3Method is now written to dispatch on the second argument to maintain consistency with previous versions. Therefore, the function is still defined as function(celltype_oi, seurat_obj, pct = 0.1, assay_oi = NULL, ...), which will still work with the vignettes.

codecov-commenter commented 5 months ago

Codecov Report

Attention: 97 lines in your changes are missing coverage. Please review.

Comparison is base (0e14cbe) 70.08% compared to head (17d0efd) 69.59%. Report is 14 commits behind head on master.

Files Patch % Lines
R/supporting_functions.R 26.19% 62 Missing :warning:
R/application_prediction.R 32.69% 35 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #250 +/- ## ========================================== - Coverage 70.08% 69.59% -0.50% ========================================== Files 16 16 Lines 5419 5472 +53 ========================================== + Hits 3798 3808 +10 - Misses 1621 1664 +43 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.