saezlab / CARNIVAL

CAusal Reasoning for Network Identification with integer VALue programming in R
https://saezlab.github.io/CARNIVAL/
57 stars 29 forks source link

current_dir and dir_name conflict #10

Closed rosherbal closed 5 years ago

rosherbal commented 5 years ago

I have realized that some times runCARNIVAL founds solutions, but the pipeline retrieves "No result to be written", without giving any error/warning message.

I have dug in the code, and I have found that it puts together _currentdir and _dirname. _currentdir gets the current working directory, and if the _dirname is an absolute path, then you can end up with a nested path that doesn't exist. Due to this conflict, even if there are solutions to be generated, they are never written.

Be aware that the argument for _Resultdir must NOT be an absolute path.

ptrairatphisan commented 5 years ago

@rosherbal - Thank you very much for your report. Indeed the runCARNIVAL function doesn't support the assignment of a full file path as the name of result folder (e.g. "/home/user/CARNIVAL_Results"). Yet, it still support the assignment of sub-folder (e.g. "output/CARNIVAL_Results").

This remark has now been added to the README page on the master branch and also documented in the FAQ section of CARNIVAL Wiki page.