search

saezlab / CARNIVAL

CAusal Reasoning for Network Identification with integer VALue programming in R
https://saezlab.github.io/CARNIVAL/
57 stars 29 forks source link

node name fixing #24

Closed gabora closed 3 years ago

gabora commented 4 years ago

the formatting of node names are done independently for network (controlNodeIdentifiers) , inputs (checkInputObj) and measurements (checkMeasObj). This should be handled by the same function, if possible, to assure they are done the same way.

gabora commented 4 years ago

Worse! If a name has an invalid character for CPLEX, for example a dash (-) , then the name is converted in the networkObj and then it checks which measurements are in the networkObj. This way, the name appears with a dash in the measurement, but already with underscore in the networkObj and won't match.

enio23 commented 4 years ago

Indeed that could bring issues. Symbol conversion now is performed before removing non-present measurements.

ivanovaos commented 3 years ago

Redundant code is removed. All called from one place.