saezlab / CARNIVAL

CAusal Reasoning for Network Identification with integer VALue programming in R
https://saezlab.github.io/CARNIVAL/
57 stars 29 forks source link

Constraint writing takes a very long time #26

Closed ivanovaos closed 2 years ago

ivanovaos commented 4 years ago

Review the code part that does it and find optimisations

Reported by Aurelien

enio23 commented 4 years ago

Constraint writing is fast except for the ones in write_constraints_6.R and write_constraints_7.R. They are a bit tricky.

ivanovaos commented 4 years ago

@enio can you please comment on this opened issue? https://github.com/saezlab/CARNIVAL/issues/15

ivanovaos commented 3 years ago

String parsing is not necessary anymore with new internal data representation. Likely, constraints writing is taking much less time and can even be done locally. Requires an extra check/profiling on time.