saezlab / CARNIVAL

CAusal Reasoning for Network Identification with integer VALue programming in R
https://saezlab.github.io/CARNIVAL/
57 stars 29 forks source link

Wrong column name inside the measurementsDf? #69

Closed dingquanyu closed 3 years ago

dingquanyu commented 3 years ago

From create_lp_formulation.R, functioncreateGenerals_v2 :

generals <- paste(c(variables$nodesDf$nodesVars,
                      variables$nodesDf$nodesActStateVars,
                      variables$measurementsDf$absDifference), sep="\t")

Hello all. Thanks a lot for putting up such fantastic work!

Very sorry for this non-error issue but I wonder if variables$measurementsDf$absDifference here should be variables$measurementsDf$value instead? There is no error running the pipeline like this though.

Having tried this part of the code, I also realised the two values from the toy_measurements_ex1.RData were not written down at the end of the Generals in the toy_lp_file_ex1.lp file. Should it be like this? Or is it because those values happen to be 1 so when writing output, it just writes two \t?

Thanks a lot.

ivanovaos commented 3 years ago

Hi @HenryWotton,

Thank you, you are very observant! That was indeed a bug that is already fixed in the next bump prepared for submission :)