search

saezlab / CARNIVAL

CAusal Reasoning for Network Identification with integer VALue programming in R
https://saezlab.github.io/CARNIVAL/
57 stars 29 forks source link

Another version(V3) of the function that creates constraints 6 and 7 #70

Closed dingquanyu closed 3 years ago

dingquanyu commented 3 years ago

Hello all,

Thanks a lot for your fantastic work and prompt reply to my question! I'm actually from EMBL-HH site and sorry for my messy usernames. I somehow could not reproduce the results in toy_lp_file_ex1.lp file after running the createConstraint_6_7_v2 function so I have modified some parts of it. I have also tested with the toy data and found out the V3 version can reproduce the results in toy_lp_file_ex1.lp file. Perhaps you've already have this in mind?

Thanks.

ivanovaos commented 3 years ago

Thanks for your pull request, @HenryWotton I tried to find the discrepancy in running the function and checking the file, and I cannot find it. Can you please point out what was exactly different for you? Running the function from pull request on toy examples variables returns NULL results for both c6 and c7. Can you highlight the updates?

Thanks!

dingquanyu commented 3 years ago

Thanks for your pull request, @HenryWotton I tried to find the discrepancy in running the function and checking the file, and I cannot find it. Can you please point out what was exactly different for you? Running the function from pull request on toy examples variables returns NULL results for both c6 and c7. Can you highlight the updates?

Thanks!

Thanks for pointing it out and very sorry for the late reply. I've fixed the issues and it can replicate line 35 and line 46 in the toy_lp_file_ex1.lp file.

It's quite strange because when I tried the V2 of this script locally in July, I couldn't get line 38 and line 46 among those lines. Then I wrote the function from scratch just to produce the last 8 lines. However, I tested the V2 script again locally this morning and it worked this time. Sorry there isn't actually any change in the fundamental logic in V3 script. Honestly, it's just performing the same task as V2.

ivanovaos commented 3 years ago

No worries, thanks for the work and the update!