search

saezlab / MetaProViz

R-package to perform metabolomics pre-processing, differential metabolite analysis, metabolite clustering and custom visualisations.
https://saezlab.github.io/MetaProViz/
GNU General Public License v3.0
8 stars 0 forks source link

Preprocessing comment #19

Closed ChristinaSchmidt1 closed 1 year ago

ChristinaSchmidt1 commented 1 year ago

In the preprocessing function line 186 you commented "## Check complete.case instead of is.na. it is faster and you dont have to use which". I removed the comment, but if you still want to make those changes troughout the function, please do so and afterwards close this issue.

dprymidis commented 1 year ago

Complete.cases works row-wise in dataframes. So we have to transpose the dataframe. I dont know what is faster in big scale. If we use it instead of is.na per column we still have to use which. I will leave it as it is and keep this as a note maybe for a future update.