Closed dprymidis closed 1 year ago
Yes, this is correct and is intended in this way. Some explanation here:
Does this makes sense?
Maybe we could add an example of choosing UP- and Down regulated clusters and running the ORA on those too in the vignette
for 1 and 3 ok it makes sence. For 2, I am a bit concerened because taking the 10% or any other percentage seems a bit arbitrary. Like it will always result in something and people might think they got results even though they dont, just because they see some plots. You know what I mean? While filtering with padj and logFC will not do this .
Thats a valid point. In most cases this should be significant changes as otherwise the comparison has no differences. What we can do is that whatever % choosen, we give a warning if features falling into this are not significantly and/or have Log2FC <0.05.
All done. I will move the last point into an lollipop graph issue we can work on in the furture.
In DM_ORA, I noticed that we rank metabolites based on t.value and then take the top and bottom 10% together and an input for ORA. Is this correct?
Why do we take 10%? is there a specific reason? Wouldnt it be better is we filtered for significance of padj and log2FC ?
Also, shouldnt we separate the upregulated from the downregulated metabolites and run ORA on the 2 subsets separately?