saezlab / MetaProViz

R-package to perform metabolomics pre-processing, differential metabolite analysis, metabolite clustering and custom visualisations.
https://saezlab.github.io/MetaProViz/
GNU General Public License v3.0
11 stars 1 forks source link

In preprocessing add ExportQCPlots=TRUE #9

Closed ChristinaSchmidt1 closed 1 year ago

ChristinaSchmidt1 commented 1 year ago

I would add the parameter and make the default =TRUE. Default parameters are meant to not be changed unless necessary and in this case it just adds functionality. Yet, this is not something which is urgent, but the reason for doing these things is if someone runs big data meaning processes 500 experiements in a row, they dont want to generate all the folders which takes storage and delete them again.

dprymidis commented 1 year ago

I added:

' @param ExportQCPlots \emph{Optional: } Select whether the quality control (QC) plots will be exported. \strong{Default=TRUE}

and if (ExportQCPlots == TRUE){ ... } before the QC folder creation and the save of the QC plots.

ChristinaSchmidt1 commented 1 year ago

Perfect, shall we close this issue?

dprymidis commented 1 year ago

Yes