saezlab / liana-py

LIANA+: an all-in-one framework for cell-cell communication
http://liana-py.readthedocs.io/
GNU General Public License v3.0
156 stars 21 forks source link

Difference on dotplot when running Steady-state Ligand-Receptor inference vignette from the Rank Aggregate section #81

Closed maximelepetit closed 8 months ago

maximelepetit commented 8 months ago

Describe the bug Hi ! I'm currently running the Steady-state Ligand-Receptor inference vignette from (https://liana-py.readthedocs.io/en/latest/notebooks/basic_usage.html).

I noticed a bug when running the second dotplot from the Rank Aggregate section.

I obtained :

Screenshot from 2024-01-09 12-47-57

Instead of :

Screenshot from 2024-01-09 12-58-15

It should be noted that i change filter_fun parameter by filter_lambda parameter from li.pl.dotplot() function. #80

Best regards

Maxime

maximelepetit commented 8 months ago

My environnement session :

# packages in environment at /home/labex-cortex/miniconda3/envs/liana-env:
#
# Name                    Version                   Build  Channel
_libgcc_mutex             0.1                        main  
_openmp_mutex             5.1                       1_gnu  
aiohttp                   3.8.6                    pypi_0    pypi
aiosignal                 1.3.1                    pypi_0    pypi
alabaster                 0.7.13             pyhd8ed1ab_0    conda-forge
anndata                   0.9.2                    pypi_0    pypi
annotated-types           0.6.0                    pypi_0    pypi
asciitree                 0.3.3                    pypi_0    pypi
asttokens                 2.4.0                    pypi_0    pypi
async-timeout             4.0.3                    pypi_0    pypi
attrs                     23.1.0             pyh71513ae_1    conda-forge
babel                     2.13.0             pyhd8ed1ab_0    conda-forge
backcall                  0.2.0              pyhd3eb1b0_0    anaconda
backports-zoneinfo        0.2.1                    pypi_0    pypi
bleach                    6.1.0              pyhd8ed1ab_0    conda-forge
brotli-python             1.0.9            py38hfa26641_7    conda-forge
ca-certificates           2023.7.22            hbcca054_0    conda-forge
cell2cell                 0.6.6                    pypi_0    pypi
certifi                   2023.7.22                pypi_0    pypi
cfgv                      3.4.0                    pypi_0    pypi
charset-normalizer        3.3.1              pyhd8ed1ab_0    conda-forge
clarabel                  0.6.0                    pypi_0    pypi
click                     8.1.7                    pypi_0    pypi
cloudpickle               3.0.0                    pypi_0    pypi
colorama                  0.4.6              pyhd8ed1ab_0    conda-forge
comm                      0.1.2            py38h06a4308_0    anaconda
corneto                   0.9.1a4                  pypi_0    pypi
cvxpy                     1.4.1                    pypi_0    pypi
cylp                      0.91.6                   pypi_0    pypi
dask                      2023.5.0                 pypi_0    pypi
dask-image                2023.3.0                 pypi_0    pypi
debugpy                   1.6.7            py38h6a678d5_0    anaconda
decorator                 5.1.1              pyhd3eb1b0_0    anaconda
decoupler                 1.5.0                    pypi_0    pypi
defusedxml                0.7.1              pyhd8ed1ab_0    conda-forge
distlib                   0.3.8                    pypi_0    pypi
docrep                    0.3.2                    pypi_0    pypi
docutils                  0.18.1           py38h06a4308_3  
ecos                      2.0.12                   pypi_0    pypi
entrypoints               0.4                pyhd8ed1ab_0    conda-forge
et-xmlfile                1.1.0                    pypi_0    pypi
executing                 2.0.0                    pypi_0    pypi
fasteners                 0.19                     pypi_0    pypi
filelock                  3.13.1                   pypi_0    pypi
frozenlist                1.4.0                    pypi_0    pypi
fsspec                    2023.10.0                pypi_0    pypi
gseapy                    1.0.3                    pypi_0    pypi
h5py                      3.10.0                   pypi_0    pypi
identify                  2.5.33                   pypi_0    pypi
idna                      3.4                pyhd8ed1ab_0    conda-forge
igraph                    0.10.8                   pypi_0    pypi
imageio                   2.31.6                   pypi_0    pypi
imagesize                 1.4.1              pyhd8ed1ab_0    conda-forge
importlib-metadata        6.8.0                    pypi_0    pypi
importlib_metadata        6.0.0                hd3eb1b0_0    anaconda
importlib_resources       6.1.0              pyhd8ed1ab_0    conda-forge
inflect                   7.0.0                    pypi_0    pypi
ipykernel                 6.25.2             pyh2140261_0    conda-forge
ipython                   8.12.3                   pypi_0    pypi
jedi                      0.19.1                   pypi_0    pypi
jinja2                    2.11.3             pyhd8ed1ab_2    conda-forge
jsonschema                4.17.3             pyhd8ed1ab_0    conda-forge
jupyter_client            8.1.0            py38h06a4308_0    anaconda
jupyter_core              5.3.0            py38h06a4308_0    anaconda
kneed                     0.8.5                    pypi_0    pypi
lazy-loader               0.3                      pypi_0    pypi
ld_impl_linux-64          2.38                 h1181459_1  
leidenalg                 0.10.1                   pypi_0    pypi
liana                     1.0.3                    pypi_0    pypi
libffi                    3.4.4                h6a678d5_0  
libgcc-ng                 11.2.0               h1234567_1  
libgomp                   11.2.0               h1234567_1  
libsodium                 1.0.18               h7b6447c_0    anaconda
libstdcxx-ng              11.2.0               h1234567_1  
llvmlite                  0.41.1                   pypi_0    pypi
locket                    1.0.0                    pypi_0    pypi
markupsafe                1.1.1            py38h497a2fe_3    conda-forge
matplotlib-inline         0.1.6            py38h06a4308_0    anaconda
matplotlib-scalebar       0.8.1                    pypi_0    pypi
mistune                   0.8.4           pyh1a96a4e_1006    conda-forge
mizani                    0.9.3                    pypi_0    pypi
mofax                     0.3.6                    pypi_0    pypi
mudata                    0.2.3                    pypi_0    pypi
multidict                 6.0.4                    pypi_0    pypi
muon                      0.1.5                    pypi_0    pypi
natsort                   8.4.0                    pypi_0    pypi
nbconvert                 5.6.1            py38h32f6830_1    conda-forge
nbformat                  5.9.2              pyhd8ed1ab_0    conda-forge
nbsphinx                  0.9.3              pyhd8ed1ab_0    conda-forge
ncurses                   6.4                  h6a678d5_0  
nest-asyncio              1.5.6            py38h06a4308_0    anaconda
nodeenv                   1.8.0                    pypi_0    pypi
nose                      1.3.7                    pypi_0    pypi
numba                     0.58.1                   pypi_0    pypi
numcodecs                 0.12.1                   pypi_0    pypi
numpydoc                  1.5.0              pyhd8ed1ab_0    conda-forge
omnipath                  1.0.7                    pypi_0    pypi
openpyxl                  3.1.2                    pypi_0    pypi
openssl                   3.0.11               h7f8727e_2    anaconda
osqp                      0.6.3                    pypi_0    pypi
packaging                 23.1             py38h06a4308_0    anaconda
pandas                    1.5.3                    pypi_0    pypi
pandoc                    2.19.2               ha770c72_0    conda-forge
pandocfilters             1.5.0              pyhd8ed1ab_0    conda-forge
parso                     0.8.3              pyhd3eb1b0_0    anaconda
partd                     1.4.1                    pypi_0    pypi
patsy                     0.5.3                    pypi_0    pypi
pexpect                   4.8.0              pyhd3eb1b0_3    anaconda
pickleshare               0.7.5           pyhd3eb1b0_1003    anaconda
pillow                    10.0.1                   pypi_0    pypi
pims                      0.6.1                    pypi_0    pypi
pip                       23.3             py38h06a4308_0  
pkgutil-resolve-name      1.3.10             pyhd8ed1ab_1    conda-forge
platformdirs              3.10.0           py38h06a4308_0    anaconda
plotnine                  0.12.3                   pypi_0    pypi
pre-commit                3.5.0                    pypi_0    pypi
prompt-toolkit            3.0.39                   pypi_0    pypi
prompt_toolkit            3.0.36               hd8ed1ab_0    conda-forge
protobuf                  4.24.4                   pypi_0    pypi
psutil                    5.9.0            py38h5eee18b_0    anaconda
ptyprocess                0.7.0              pyhd3eb1b0_2    anaconda
pure_eval                 0.2.2              pyhd3eb1b0_0    anaconda
pybind11                  2.11.1                   pypi_0    pypi
pydantic                  2.4.2                    pypi_0    pypi
pydantic-core             2.10.1                   pypi_0    pypi
pydeseq2                  0.4.1                    pypi_0    pypi
pygments                  2.16.1                   pypi_0    pypi
pynndescent               0.5.10                   pypi_0    pypi
pyrsistent                0.18.0           py38heee7806_0  
pysocks                   1.7.1              pyha2e5f31_6    conda-forge
python                    3.8.18               h955ad1f_0  
python-dateutil           2.8.2              pyhd3eb1b0_0    anaconda
python-fastjsonschema     2.18.1             pyhd8ed1ab_0    conda-forge
python_abi                3.8                      2_cp38    conda-forge
pytz                      2023.3.post1       pyhd8ed1ab_0    conda-forge
pywavelets                1.4.1                    pypi_0    pypi
pyyaml                    6.0.1                    pypi_0    pypi
pyzmq                     25.1.0           py38h6a678d5_0    anaconda
qdldl                     0.1.7.post0              pypi_0    pypi
readline                  8.2                  h5eee18b_0  
requests                  2.31.0             pyhd8ed1ab_0    conda-forge
scanpy                    1.9.5                    pypi_0    pypi
scikit-image              0.21.0                   pypi_0    pypi
scs                       3.2.3                    pypi_0    pypi
seaborn                   0.11.2                   pypi_0    pypi
session-info              1.0.0                    pypi_0    pypi
setuptools                68.0.0           py38h06a4308_0  
six                       1.16.0             pyhd3eb1b0_1    anaconda
slicerator                1.1.0                    pypi_0    pypi
snowballstemmer           2.2.0              pyhd8ed1ab_0    conda-forge
sphinx                    5.0.2              pyh6c4a22f_0    conda-forge
sphinx_rtd_theme          1.3.0              pyha770c72_0    conda-forge
sphinxcontrib-applehelp   1.0.2              pyhd3eb1b0_0  
sphinxcontrib-devhelp     1.0.2              pyhd3eb1b0_0  
sphinxcontrib-htmlhelp    2.0.0              pyhd3eb1b0_0  
sphinxcontrib-jquery      4.1                pyhd8ed1ab_0    conda-forge
sphinxcontrib-jsmath      1.0.1              pyhd8ed1ab_0    conda-forge
sphinxcontrib-qthelp      1.0.3              pyhd3eb1b0_0  
sphinxcontrib-serializinghtml 1.1.5              pyhd3eb1b0_0  
sqlite                    3.41.2               h5eee18b_0  
squidpy                   1.2.2                    pypi_0    pypi
stack-data                0.6.3                    pypi_0    pypi
stack_data                0.2.0              pyhd3eb1b0_0    anaconda
statannotations           0.6.0                    pypi_0    pypi
statsmodels               0.14.0                   pypi_0    pypi
stdlib-list               0.9.0                    pypi_0    pypi
tbb                       2021.10.0                pypi_0    pypi
tensorly                  0.7.0                    pypi_0    pypi
testpath                  0.6.0              pyhd8ed1ab_0    conda-forge
texttable                 1.7.0                    pypi_0    pypi
tifffile                  2023.7.10                pypi_0    pypi
tk                        8.6.12               h1ccaba5_0  
toolz                     0.12.0                   pypi_0    pypi
tornado                   6.3.3            py38h5eee18b_0    anaconda
tqdm                      4.66.1                   pypi_0    pypi
traitlets                 5.7.1            py38h06a4308_0    anaconda
typing-extensions         4.8.0                    pypi_0    pypi
typing_extensions         4.7.1            py38h06a4308_0    anaconda
tzdata                    2023.3                   pypi_0    pypi
umap-learn                0.5.4                    pypi_0    pypi
urllib3                   2.0.7              pyhd8ed1ab_0    conda-forge
validators                0.22.0                   pypi_0    pypi
virtualenv                20.25.0                  pypi_0    pypi
wcwidth                   0.2.8                    pypi_0    pypi
webencodings              0.5.1              pyhd8ed1ab_2    conda-forge
wheel                     0.41.2           py38h06a4308_0  
xarray                    2023.1.0                 pypi_0    pypi
xlrd                      2.0.1                    pypi_0    pypi
xz                        5.4.2                h5eee18b_0  
yarl                      1.9.2                    pypi_0    pypi
zarr                      2.16.1                   pypi_0    pypi
zeromq                    4.3.4                h2531618_0    anaconda
zipp                      3.17.0                   pypi_0    pypi
zlib                      1.2.13               h5eee18b_0  
dbdimitrov commented 8 months ago

Yes, please upgrade the liana version:

pip install git+https://github.com/saezlab/liana-py --upgrade

I added the --upgrade flag just in case. Maybe pip doesn't register that the version on github is different.

I will release 1.0.4 to pip soon.

This should resolve it.

maximelepetit commented 8 months ago

This work fine !!