saezlab / liana

LIANA: a LIgand-receptor ANalysis frAmework
https://saezlab.github.io/liana/
GNU General Public License v3.0
178 stars 32 forks source link

Unable to choose multiple resources and call_cellchat not working #87

Closed shikhanayar closed 1 year ago

shikhanayar commented 1 year ago

Hello,

Thank you so much for LIANA! Such a great way to test robustness of findings across different methods and underlying resource utility. I am facing 2 errors, which I was hoping you could help me debug (for context, I am running LIANA on a Seurat rds object).

Issue 1: selecting multiple resources crashes the run

Issue 2: call_cellchat function fails, even with just using one resource

Please let me know if I can provide any other useful items to help with the debugging and thank you in advance!

dbdimitrov commented 1 year ago

Hi @shikhanayar,

I couldn't reproduce the first issue, it works with the test data on my machine, and I get a list of results for c('CellPhoneDB', 'CellChatDB') as expected.

liana_path <- system.file(package = "liana")
seurat_object <-
    readRDS(file.path(liana_path , "testdata", "input", "testdata.rds"))

liana_res <- liana_wrap(seurat_object, method = c('cellphonedb'), resource = c('CellPhoneDB', 'CellChatDB'), expr_prop=0.1)

In the updated version of liana (0.1.11), I fixed this issue.

Hope this helps!

Daniel

shikhanayar commented 1 year ago

Thanks Daniel! I'll make sure I have the most updated version of LIANA installed and try to rerun (I'm assuming you meant that you fixed the second issue I mentioned -- using call_cellchatas the sole method?).