search

saezlab / networkcommons

https://networkcommons.readthedocs.io
GNU General Public License v3.0
1 stars 0 forks source link

10 add method moon reimplementation #23

Closed vicpaton closed 3 weeks ago

vicpaton commented 4 weeks ago

This PR closes #10 This PR closes #18

codecov-commenter commented 4 weeks ago

Codecov Report

Attention: Patch coverage is 87.82201% with 52 lines in your changes missing coverage. Please review.

Project coverage is 82.16%. Comparing base (4eb33df) to head (8881f84). Report is 12 commits behind head on main.

:exclamation: Current head 8881f84 differs from pull request most recent head 9400018

Please upload reports for the commit 9400018 to get more accurate results.

Files Patch % Lines
networkcommons/moon.py 82.84% 41 Missing :warning:
networkcommons/prior_knowledge.py 22.22% 7 Missing :warning:
networkcommons/utils.py 25.00% 3 Missing :warning:
networkcommons/visualization.py 0.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #23 +/- ## ========================================== + Coverage 79.71% 82.16% +2.45% ========================================== Files 10 12 +2 Lines 557 998 +441 ========================================== + Hits 444 820 +376 - Misses 113 178 +65 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

vicpaton commented 3 weeks ago

Added MOON as a method and a notebook copying the vignette in R. Still there are some differences in the compression implemented here and the one implemented in R, but it only targets very unusual cases that are taken into account in this version.