search

safafa / NY_Times_article

new york times article clone
5 stars 0 forks source link

Article #1

Open safafa opened 3 years ago

safafa commented 3 years ago

HTML skeleton : Semantic html tags to create a perfect outline Flexbox and float grid element to adjust the positions of the elements Second Code review request : I applied the changes I configured the linters locally using this repo instructions. the stylelint linter doesn't run and keeps throwing this error. image

safafa commented 3 years ago

@teekaytech Thank you so much for the review. Can you please show me how can I configure the linters locally ?

teekaytech commented 3 years ago

@teekaytech Thank you so much for the review. Can you please show me how can I configure the linters locally ?

Of course, happy to help :blush:

Please check this repo. There's a section titled Set-up linters in your local env. This section should guide you. I must say that you do not have to set up the 3 approaches. Personally, I like using the Webhint (For HTML checks) and Stylelint (for CSS checks) approaches because they seem straightforward to me.

All the best!