search

safaricom / LNMOnlineAndroidSample

Lipa Na MPESA Online (STK Push) Android Sample Application. This app demonstrates an e-commerce purchase and checkout process via Mpesa and Daraja :smile:
https://developer.safaricom.co.ke/
Apache License 2.0
127 stars 129 forks source link

Conversion of App to Kotlin 👌 (Kotlinification) #28

Closed etonotieno closed 5 years ago

etonotieno commented 5 years ago

This PR converts the entire codebase to Kotlin and also fixes some of the UI bugs like overlapping of the text in the Recycler View. I am also planning to incorporate an architecture to showcase some best practices of making an app and also how to use the LNM api. @jumaallan @TheDancerCodes @kioko Any ideas to make this better is welcome.

jumaallan commented 5 years ago

@CodeZilla7

From what @kioko explained, they wanted to make it easy for beginners to understand how LNM works. The best way to handle your PR is forking it from your repo, as a Kotlin Sample. This will make sure the Java Sample still remains available to the Java-rians 🚀

etonotieno commented 5 years ago

That's actually a good idea. They can fork the Kotlin version that also shows some best practices to follow when creating your app. Something that's not hard to understand but also very useful especially to more experienced devs.

jumaallan commented 5 years ago

Yes, that would be the best way to handle it. I could help fork the repo once it's done

kisese commented 5 years ago

The main aim of these repos is to show how to use the APIs in as many languages as possible, so it would be best to do kotlin in a new repo so we keep java, as long as you maintain the same UX flow, keep the code easy to understand for all levels of developers and prioritise how to use the API