search

safaricom / mpesa-php-sdk

A PHP sdk for the new Mpesa RESTful APIs
188 stars 211 forks source link

env variables returning null if config is cached #11

Open jeygith opened 6 years ago

jeygith commented 6 years ago

Hi! good work on this however, there's a slight issue with how you get the env variables in the Mpesa class. Once the config is cached, via config:cache, the .env file is no longer loaded and calls to the env function return null. I'd suggest you create a config file for the sdk where the consumer keys and secret or any other variable can be set.

mossey commented 6 years ago

Hello @jeygith , thanks for the feedback. I have taken the issue into consideration and we will include that fix in our next release.

nikklass commented 6 years ago

These can be fixed on the move, you dont need to wait for a whole release to correct such. Are pull requests ok?

mossey commented 5 years ago

Yeah @nikklass PRs are okay

jaymoh commented 3 years ago

@nikklass hi, did you create this pull request?