adding cmd and msglvl - Githubissues

safchain / ethtool

A simple ethtool "like" library for GO

Apache License 2.0

120 stars 69 forks source link

adding cmd and msglvl #1

Closed minghuadev closed 7 years ago

minghuadev commented 8 years ago

hi, thanks for sharing the nice code. can I suggest some enhancement to add two commands/calls? the diff to ethtool.go and 4 additional files are attached. feel free to use or tailor as you see that suits.

sorry github only allows certain file types. all the file names are suffixed by .txt .

ethtool.go-diff.txt ethtool_cmd.go.txt ethtool_cmd_test.go.txt ethtool_msglvl.go.txt ethtool_msglvl_test.go.txt

safchain commented 8 years ago

Hi, looks good, thx for the enhancements. Maybe you could send a pull request so that the reviewing process will be easier and you will be seen as contributor.

minghuadev commented 8 years ago

sent #7 pull-request which passed the travis test. please advise any further modifications necessary to get it merged. thanks.