search

safchain / ethtool

A simple ethtool "like" library for GO
Apache License 2.0
120 stars 69 forks source link

Add support for getting module eeprom #14

Closed ake-persson closed 6 years ago

ake-persson commented 7 years ago
ake-persson commented 7 years ago

Same as "ethtool -m eth0 hex on"

ake-persson commented 7 years ago

Started adding module info

ake-persson commented 7 years ago

That finished support for module eeprom and SFF-8079 info.

ake-persson commented 7 years ago

I'm adding additional code for QFP 8636, so better to merge until after that. I'll address your comments as-well.

ake-persson commented 7 years ago

I will split out the SFF decode part in a separate package otherwise you'll have to deal with license conflict GPL from orig. ethtool vs Apache. Since the code is basically a copy/paste of their code from C to Go. I have to respect their original license. https://github.com/mickep76/sff-eeprom

ake-persson commented 6 years ago

Fixed the comments in the review, sry for the delay. I implemented a module decoder separately mostly because it needed a diff. license. I ended up completely re-factoring anyway so I can merge it in to this code base if you think that make sense? (https://github.com/mickep76/go-sff)

safchain commented 6 years ago

Sorry for the delay, thanks a lot