safchain / ethtool

A simple ethtool "like" library for GO
Apache License 2.0
116 stars 69 forks source link

Update MAX_GSTRINGS to 16384 #42

Closed fach closed 3 years ago

fach commented 3 years ago

When attempting to use the ethtool stats collector in prometheus node exporter which leverages this lib, I'm hitting the 8k limit set in MAX_GSTRINGS due to NICs with a large number of channels and rx/tx queues due to overall system core counts (i.e. 128 cpu cores). This increases the overall number of stats exported:

Aug 03 00:02:08 node_exporter[1728339]: level=error ts=2021-08-03T00:02:08.271Z caller=ethtool_linux.go:154 collector=ethtool msg="ethtool stats error" err="ethtool currently doesn't support more than 8192 entries, received 8979">

This PR raises the MAX_GSTRINGS limit to 16k.