safe-global / safe-android

🔐 App to manage and interact with Safe
https://safe.global
GNU General Public License v3.0
91 stars 38 forks source link

[Keystone integration] Can not sign with keystone key already created tx #1922

Open liliya-soroka opened 1 year ago

liliya-soroka commented 1 year ago

Describe the bug Can not sign with keystone key already created tx

To Reproduce Steps to reproduce the behavior:

  1. Add keystone key as a signer for your Goerli safe n of m
  2. create tx using another key ( not keystone key) ( I have created transfer goerli ETH tx from the android mobile app or reject any tx using another key and try to sign rejected tx with keystone key)
  3. go to the Queued
  4. Try to sign any existed tx using keystone key

Current result Sometimes the QR code is presented but the failed to sign error is displayed. In most cases the QR code is not displayed together with "failed to sign" error message Expected behavior Make sure that it's possible to sign any existed tx using keystone key

Screenshots

image

Smartphone (please complete the following information):

Environment staging Additional context related to https://github.com/safe-global/safe-android/pull/1911

zhiying-fan commented 1 year ago

This is fixed, please have a look again.

liliya-soroka commented 1 year ago

the issue is reproducible in the latest debug version - please, check slack channel for the latest app version