search

safe-global / safe-android

🔐 App to manage and interact with Safe
https://safe.global
GNU General Public License v3.0
91 stars 38 forks source link

[Android]Tx execution - Edit Nonce on Edit tx fee page doesn't work #1975

Open liliya-soroka opened 1 year ago

liliya-soroka commented 1 year ago

Describe the bug Edit Nonce on the Edit tx fee page doesn't work

To Reproduce Steps to reproduce the behavior:

  1. Go to the tx execution screen

  2. Click Estimated fee

  3. try to edit nonce and save changes

  4. reopen Edit tx fees Current result: Entered nonce is not saved

  5. try to enter the default nonce Current result: The error that the tx with this nonce was already executed is displayed

Expected behavior Make sure that:

  1. It's possible to edit the nonce and saved nonce is used for execution
  2. the error should not be displayed for the valid minimum nonce

Screenshots https://drive.google.com/file/d/14aV8G351oJPlc469sXfmDZMxEBncamPM/view?usp=sharing

Smartphone (please complete the following information):

Environment staging Additional context related to https://github.com/safe-global/safe-android/issues/1932

liliya-soroka commented 1 year ago

Verified app version 3.8.0 -4000 Empty state Executed nonce too big nonce save and cancel saving