safe-global / safe-android

🔐 App to manage and interact with Safe
https://safe.global
GNU General Public License v3.0
91 stars 38 forks source link

Monitor transaction submitted for execution #1990

Closed elgatovital closed 1 year ago

elgatovital commented 1 year ago

Handles #1987

Changes proposed in this pull request:

@gnosis/mobile-devs

elgatovital commented 1 year ago

Please add tests for the new repository

Edit: Also a couple view models have new logic which should also be tested

yes, already have task for it https://github.com/safe-global/safe-android/issues/1963

rmeissner commented 1 year ago

We should not merge new logic without tests. It makes little sense to do the tests in a separate PR :thinking: