search

safe-global / safe-android

🔐 App to manage and interact with Safe
https://safe.global
GNU General Public License v3.0
91 stars 38 forks source link

problem with statuses and stepper on the tx details page during signing and execution txs #1994

Open liliya-soroka opened 1 year ago

liliya-soroka commented 1 year ago

Describe the bug Problem with statuses and stepper on 2nd signing and execution of the tx

Precondition: safe 2 of N

To Reproduce 1st case

  1. Create tx in the mobile app
  2. Open tx details to sign it as a second owner
  3. Pulldown to update the tx details Current result: The second signature disappears from the stepper and "execution is required" is changed to the "confirmation is required"
  4. sign again and try to execute without pulling the updates
  5. click "View tx details" after execution
  6. "your confirmation is required is displayed as a state
  7. pull down to update the tx details Current result: Cancelled state is displayed and pulling down will not help in the status updating Expected result: The correct state should be displayed when the pull to refresh is used

2nd:

  1. there is a created tx

  2. sign the tx as a second owner Current result: the second signature doesn't appear on the tx details without pull down to refresh

  3. Execute tx after pull to refresh for signature updates Current result: Pending status has wrong view ( check the design for the ios), execution step disappears from the stepper Expected behavior Make sure that pending status and stepper looks simular to the ios ( Execute status should not disappear from the stepper) - ios app view

    image

Screenshots https://drive.google.com/file/d/16W4kWllQIJCrfEuik76EO-X4OxFlruoR/view?usp=sharing https://drive.google.com/file/d/16XCBJ6FTR74xhk5JXV0MeQy3EG9qG07t/view?usp=sharing

Smartphone (please complete the following information):

Environment prod Additional context Add any other context about the problem here.

biafra23 commented 1 year ago
  1. Pulldown to update the tx details Current result: The second signature disappears from the stepper and "execution is required" is changed to the > "confirmation is required"

This might be a caching issue on the backend When I look at response from the server it only contains one confirmation. Does iOS add the second confirmation locally?

liliya-soroka commented 1 year ago

Verified

  1. pull to refresh is required to see confirmation and executed state, but all states are displayed correctly without the issues
  2. pending state looks good in the status block and in the stepper

app version 3.9.0-4056rc