search

safe-global / safe-android

🔐 App to manage and interact with Safe
https://safe.global
GNU General Public License v3.0
90 stars 38 forks source link

Fingerprint sensor can't be enabled #249

Closed tschubotz closed 6 years ago

tschubotz commented 6 years ago

Describe the bug I used to be able to enable the fingerprint for signing transactions and unlocking the app. Now not anymore.

To Reproduce In onboarding

  1. Clean install
  2. Setup pw
  3. I end up inside the Safe, but expected to get asked if I want to enable fingerprint

In Settings

  1. I have a app (no Safe created yet)
  2. I open settings
  3. I see that fingerprint is disabled
  4. Nothing happens when tapping the toggle.

Expected behavior I expect to be able to use the fingerprint sensor

Screenshots

Smartphone (please complete the following information):

Additional context

rmeissner commented 6 years ago

Seems this might be related to https://github.com/gnosis/safe-android/commit/919fd4b19365da0c12f35dd070369b223309e427#diff-c8cc2dd42271f2bf39c6aa81eb6a5529L7

fmrsabino commented 6 years ago

I'm going to revert this change.

android.permission.USE_BIOMETRIC" requires the BiometricPrompt which is part of androidx.biometric:biometric

This requires some bigger changes including UI/UX changes that need to be discussed since with the new version we have a unified interface for user authentication (Unified biometric authentication dialog).