safe-global / safe-apps-list

MIT License
20 stars 32 forks source link

Update Mean Finance with "Optimized with batch transactions" tag and add to new chains #236

Closed FiboApe closed 1 year ago

FiboApe commented 1 year ago

Revision checks

Name/Description

We recently added bundling of transactions so Gnosis Safe users can just submit one transaction for approval + any other action that they need to do. Also we recently released our Meta Aggregator (Which is an aggregator of aggregators) which allows users to swap at the BEST price in all of defi, would love to get Mean Finance added to those chains too

Type

Compatible Networks

Audit document

Smart contracts (all verified):

Audits:

Code for review

FE Repo: https://github.com/Mean-Finance/dca-fe Safe Service: https://github.com/Mean-Finance/dca-fe/blob/main/src/services/safeService.ts Deposit bundle: https://github.com/Mean-Finance/dca-fe/blob/dc1ef0a80951dc79502479eeeaaa3ebd628d0948/src/services/positionService.ts#L711 Swap bundle: https://github.com/Mean-Finance/dca-fe/blob/dc1ef0a80951dc79502479eeeaaa3ebd628d0948/src/services/aggregatorService.ts#L77 Increase bundle: https://github.com/Mean-Finance/dca-fe/blob/dc1ef0a80951dc79502479eeeaaa3ebd628d0948/src/services/positionService.ts#L1032

And this is the PR where we added the bundling of transactions: https://github.com/Mean-Finance/dca-fe/pull/346

IPFS hash/App URL

https://mean.finance

Team information

- Project logo:  ![meanlogo](https://user-images.githubusercontent.com/94012134/226932695-a3a657a9-2c6a-4daa-801a-e18526b9303b.svg)
- Project landing page: https://mean.finance
- Team or discord contact: http://discord.mean.finance
- Twitter link: https://twitter.com/mean_fi
- Github link: https://github.com/Mean-Finance/
JagoFigueroa commented 1 year ago

Hi there! QA from safe apps here 😄 I've been playing with the app on on Gnosis Chain and BSC and I see that once I open it I am redirected to /invest:

Screenshot 2023-03-23 at 11 39 35

The thing is that the feature only looks to be available for the 4 chains seen on the screenshot (we have the app listed for those already). Is this expected?

If not, would it be possible to redirected the users automatically to /swap for the chains that do not support investing for now?

Thanks!

FiboApe commented 1 year ago

Hey @JagoFigueroa thanks for taking a look at this!

Yeah it's expected since Invest only allows for those 4 networks, but the swap page allows for a lot more.

We could do that for safe chains that are not supported by DCA, would this be a blocker for this issue?

JagoFigueroa commented 1 year ago

That would be awesome, thanks! We can add the app to the list for rest of the chains beforehand 😄

Re-checked today and everything looks good, will let the team know and after some final checks the app (+ info) should be all bueno to be added to the remaining chains on the list that we support: Gnosis Chain, BSC, Avalanche & Aurora.

We will notify here with a message when the addition is performed.

Cheers!

dasanra commented 1 year ago

Update is published now