safe-global / safe-apps-list

MIT License
20 stars 30 forks source link

Sablier V2 #269

Closed maxdesalle closed 1 year ago

maxdesalle commented 1 year ago

Revision checks

Name/Description

Name: Sablier V2 Description: The token streaming protocol.

Type

Compatible Networks

- Mainnet
- Goerli
- Gnosis Chain
- Avalanche
- Binance Smart Chain
- Polygon
- Optimism
- Arbitrum

Audit document

https://github.com/sablier-labs/audits

Code for review

https://github.com/sablier-labs/v2-interfaces

IPFS hash/App URL

https://app.sablier.com

Other request

Could you please update the name of the currently existing Sablier Safe app to "Sablier V1"? That will help differentiate both versions, as the current app only works for Sablier V1, while this version only supports Sablier V2. Would also appreciate if you could change the description there to "The token streaming protocol." too. Thank you! πŸ™

Team information

- Project logo: https://github.com/sablier-labs/branding/blob/main/icon/svg/icon.svg
- Project landing page: https://sablier.com
- Team or discord contact: @maxdesalle
- Twitter link: https://twitter.com/sablier
- Github link: https://github.com/sablier-labs
dasanra commented 1 year ago

@maxdesalle I think the repo is private. Could you invite me?

Thank you!

JagoFigueroa commented 1 year ago

Hi team! Looks like there is no token list available on gnosis chain at this moment, making a bit difficult to create any stream there. Could you give it a πŸ‘€ ?

Thanks!

maxdesalle commented 1 year ago

@maxdesalle I think the repo is private. Could you invite me?

Thank you!

Hey @dasanra, just invited you! Sorry for that, you should have read access now.

maxdesalle commented 1 year ago

Hi team! Looks like there is no token list available on gnosis chain at this moment, making a bit difficult to create any stream there. Could you give it a πŸ‘€ ?

Thanks!

Oh, good catch. We had listed the tokens, though, so it's probably an update issue with regards to the token list. Just shared this internally, will investigate!

maxdesalle commented 1 year ago

Are you able to access it @JagoFigueroa? Let me know if we need to give access to other people as well, we would really like it to have the Safe app live ASAP! πŸ™

JagoFigueroa commented 1 year ago

The app is working nicely for me in all chains but not on gnosis chain due to the issue I mentioned a couple of messages back 😒 if you could check that before we list it that would be awesome. SeΓ±or Daniel is the one checking the repo πŸ˜„

Cheers!

maxdesalle commented 1 year ago

The app is working nicely for me in all chains but not on gnosis chain due to the issue I mentioned a couple of messages back 😒 if you could check that before we list it that would be awesome. SeΓ±or Daniel is the one checking the repo πŸ˜„

Cheers!

Oh, my bad, meant to tag @dasanra! We are currently at EthCC but will fix the Gnosis Chain token list ASAP, and can do so even after the app is submitted (we use Uniswap's tokenlists specification).

JagoFigueroa commented 1 year ago

All good and enjoy the conferences! We will give it a final πŸ‘€ and come here with confirmation real quick πŸ˜„

JagoFigueroa commented 1 year ago

App should be listed in all chains but gnosis chain now πŸŽ‰ Let us know about the token list and we will list it there too! Also, would you like us to unlist Sablier v1?

Cheers!

maxdesalle commented 1 year ago

Wow that was quick, thank you @JagoFigueroa! We will update the Gnosis Chain tokenlist ASAP. Regarding the Sablier V1 app, could you please check the "Other requests" section in my original post? Added it below to make it easier:

Other requests

Could you please update the name of the currently existing Sablier Safe app to "Sablier V1"? That will help differentiate both versions, as the current app only works for Sablier V1, while this version only supports Sablier V2. Would also appreciate if you could change the description there to "The token streaming protocol." too. Thank you! πŸ™

JagoFigueroa commented 1 year ago

My bad! I see that it was done by @dasanra in the first place πŸ˜‚

maxdesalle commented 1 year ago

We updated the app with tokens for Gnosis Chain @JagoFigueroa! Let me know if there are any issues.

JagoFigueroa commented 1 year ago

Awesome, thanks! I see that the app is listed on gnosis chain so I will close the ticket if that is okay πŸ’ͺ