Add WOOFi

[orangechaser]

Revision checks

• [x] Used smart contracts were audited.
• [x] Your Safe App include a manifest.json file at the root with the required data.
• [x] The app can be loaded as a custom Safe App in the Apps section of https://app.safe.global.
• [x] The app auto-connects to the Safe.
• [x] You are able to trigger and execute one transaction with a Safe.
• [x] RPC requests are optimized (not triggering many requests in a very short time period).

Name/Description

WOOFi WOOFi is a unique decentralized exchange that bridges the deep liquidity of centralized exchanges on chain. This enables DeFi traders to swap with size and maximize their profits through the lowest swap fee and minimal slippage.

Type

• New addition

Compatible Networks

- Mainnet
- BNB
- Avalanche
- Fantom
- Polygon
- Arbitrum
- Optimism
- zkSync
- Base
- Polygon zkEVM
- Linea

Audit document

https://learn.woo.org/v/woofi-dev-docs/references/audits-and-bounties

Code for review

https://github.com/woonetwork

IPFS hash/App URL

https://fi.woo.org/

Team information

- Project logo:https://oss.woo.org/static/icons/WOOFi.png
- Project landing page:https://fi.woo.org/
- Team or discord contact:https://discord.com/invite/woonetwork
- Twitter link:https://twitter.com/_WOOFi
- Github link:https://github.com/woonetwork

[yagopv]

Hey @orangechaser thanks for the submission!

The app cannot be loaded as a Custom app due to a CORS error in the manifest.json

[orangechaser]

oh,sorry, App URL should be this one: https://fi.woo.org/swap/

[yagopv]

mmm sorry but now it throws an error

It seems https://fi.woo.org/swap is making an internal redirect (HTTP 301) to https://fi.woo.org/swap so it cannot be loaded

[orangechaser]

oh, It's weird, I am gonna make devops to check it. thank you.

[orangechaser]

https://app.safe.global/apps/open?safe=eth:0x01438330A81ac0290286ab7E802ACC0a838C33b3&appUrl=https%3A%2F%2Ffi.woo.org%2Fswap/

Hi sir, we can use this link to enter our app on Safe's UI.

[orangechaser]

But we still have a problem. I added https://fi.woo.org/swap/ on Safe's ‘My customer app' UI, and its link is: https://app.safe.global/apps/open?safe=arb1%3A0xD8Cbd7e0693AF1022D1c080aBEA53F0c4C62e6C5&appUrl=https%3A%2F%2Ffi.woo.org%2Fswap

It will lose a '/' at the end of the url and works error.

[yagopv]

Hey @orangechaser, we are trimming trailing slashes in the "Add Custom Safe App" dialog as we are doing comparisons between domains in several places for different reasons. Doing it without trimming will bring more issues to the table.

Knowing it works like this, we can review the Safe App and once tested we can add it with the trailing slash in our default list. Anyway, I recommend it should work both with and without trailing. Should be an easy fix for the devops

[orangechaser]

Yes, https://fi.woo.org/swap will auto jump to https://fi.woo.org/swap/ on our site.

[orangechaser]

https://app.safe.global/apps/open?safe=arb1:0xD8Cbd7e0693AF1022D1c080aBEA53F0c4C62e6C5&appUrl=https%3A%2F%2Ffi.woo.org%2Fswap

Hi @yagopv , we fixed the issue. Could we move to the next step?

[yagopv]

Hey thanks!

We cannot fetch the icon from the manifest because is being blocked:

I think you have to set the correct MIME type

[orangechaser]

Hi, It works on my side. Could you please check it again?

[yagopv]

Ok, no idea why for me is having this problem but asked some coworkers and look like it's me. I'm trying to take a look to the app code but the link is to the organization. Which repo is the Safe App one and if it is a private one could you add me to it in order to review the app?

[JagoFigueroa]

Hi team! I was checking with @yagopv and the app does load for me (these things happen 😆). Could we ask that the app automatically connects to the safe without manually connecting it for the first time?

https://github.com/5afe/safe-apps-list/assets/92332710/00f6bc53-7f57-4ea6-919f-34ae94fc7a3d

Also (this is not a requirement or anything, just in case you would like to change it for better visibility on the list of apps) looks like the app icon will not be too visible using light theme given the white color:

Cheers!

[orangechaser]

@yagopv https://github.com/woonetwork/WooPoolV2, this is all our contracts. And do you need front-end or backend code either?

[orangechaser]

@JagoFigueroa Hi, could you help us to change logo to this one? It should be better. https://oss.woo.org/static/icons/WOOFi.png.

[JagoFigueroa]

@JagoFigueroa Hi, could you help us to change logo to this one? It should be better. https://oss.woo.org/static/icons/WOOFi.png.

Sure! You would need to replace the current one you have on the manifest.json file with that one and you should be golden 😄 Please remember about the auto connect too. Cheers!

[orangechaser]

ok,thanks

[orangechaser]

https://fi.woo.org/swap/manifest.json

Hi sir, we updated the iconpath.

[yagopv]

@yagopv https://github.com/woonetwork/WooPoolV2, this is all our contracts. And do you need front-end or backend code either?

Frontend!! The Safe App

[orangechaser]

@yagopv https://github.com/woonetwork/woofi_swap_frontend/invitations.

[orangechaser]

@yagopv Hi Yagopv, may I ask what else is needed to have WOOFi listed as a default app on Safe?

[yagopv]

Hey @orangechaser, yes. One of the requirements is that the Safe App autoconnects to the Safe Account as mentioned here

[orangechaser]

Thank you @yagopv. Considering the schedule for our frontend development, we will commence this work in the coming week. Can we list WOOFi on Safe first and then complete the updates?

And If you have any other requirements, please let me know; thanks again.

[orangechaser]

We are using the full BlockNative wallet service, and I noticed that Curve is doing the same. It seems that they may not support autoconnects. Would you happen to have any suggestions about that? Thank you.

[yagopv]

Hey @orangechaser sorry, we are currently having a delay reviewing safe apps. We’ll get into it again as soon as possible

Regarding your comment, as you are using wagmi right?, you can found some docs here about how to autoconnect

[orangechaser]

No, we use Blocknative + web3.js

[yagopv]

Hey @orangechaser. We are restarting with the reviews. I checked the app and is still not autoconnecting. Did you try to fix this?

Sorry for this long delay in the review

[orangechaser]

https://fi.woo.org/swap

Does it auto-connect? Every time I log in, it will automatically connect to my safe address.