Add Everstake Ethereum Native staking app

DenEver04 commented 1 year ago

Revision checks

[x] Used smart contracts were audited.
[x] Your Safe App include a manifest.json file at the root with the required data.
[x] The app can be loaded as a custom Safe App in the Apps section of https://app.safe.global.
[x] The app auto-connects to the Safe.
[x] You are able to trigger and execute one transaction with a Safe.
[x] RPC requests are optimized (not triggering many requests in a very short time period).

Name/Description

Name: 0.1+ ETH Staking by Everstake Description: Stake your Ethereum with as little as 0.1 ETH.

Type

New addition

Compatible Networks

- Mainnet

Audit document

Audit by ChainSecurity Audit by Ackee

Code for review

The git repository is private. Please, share a git account and we will share the access to the code.

IPFS hash/App URL

https://safe-eth.everstake.one/

Team information

- Project logo: https://everstake.one/logo/logo-small-black.svg, https://everstake.one/logo/logo-small-white.svg
- Project landing page: https://everstake.one/
- Team or discord contact: https://discord.com/invite/m9YSnAsm44
- Twitter link: https://twitter.com/everstake_pool
- Github link: https://github.com/everstake

omykhailovskyi commented 10 months ago

Hey, team. Hope you are doing well. I would really appreciate it if you can provide any update in regard to this matter. Thank you in advance!

katspaugh commented 10 months ago

Hey @omykhailovskyi! As you can see your Safe App has been approved by our product manager. The next step is a technical review, which I hope to do this week. Thank you for your patience!

katspaugh commented 10 months ago

In the meanwhile, could you invite @katspaugh to the private repo?

omykhailovskyi commented 10 months ago

Hey, @katspaugh Access provided. You should have received an invite through email.

katspaugh commented 10 months ago

Thanks! Can you add me to the frontend code of the Safe App?

omykhailovskyi commented 10 months ago

Hey, @katspaugh Sure. Done. You should have received an invite through email.

katspaugh commented 10 months ago

Thanks! I've reviewed the code and can be removed from the repos now.

Feedback:

It would be good to have at least a basic unit test coverage of the frontend code but that's up to you.
A small typo: loadAutoCompount -> loadAutoCompound

Tested the app briefly:

Blocker: the proxied contract code seems to be unverified (see the details) which leads to a high risk warning from Redefine on our side
JFYI, a super-minor edge case: when staking 100k ETH, gas estimation fails with execution reverted: Pending validator, UNPREDICTABLE_GAS_LIMIT

omykhailovskyi commented 10 months ago

Hey, @katspaugh Thanks for you feedback. We will take a look. So basically contract should be verified on Etherscan, right?

katspaugh commented 10 months ago

Yes, the main contract, the proxy seems to be already verified.

omykhailovskyi commented 10 months ago

Hey, @katspaugh We have published the contract. Would really appreciate it if you can check on your side. As well fixed typo loadAutoCompount -> loadAutoCompound. Thanks for that.

omykhailovskyi commented 10 months ago

Hey, @katspaugh Hope you are doing well. Do we have anything else that block us to go live?

katspaugh commented 10 months ago

I'm still seeing the same risk warnings from Redefine.

Full report: https://dashboard.redefine.net/reports/24dbe8b7-fb88-4d99-0a0c-3a1d37200541

Please test on your side, then ping me again. You can do that by adding your app as a custom app here: https://app.safe.global/apps/custom?safe=eth:0x220866b1a2219f40e72f5c628b65d54268ca3a9d

omykhailovskyi commented 10 months ago

Hey, @katspaugh Hope you are doing well. Can we connect somehow with Redefine team if you have any direct contact? Or involve them in this issue?

highoak commented 10 months ago

Hi @omykhailovskyi. Alon from Redefine. We are checking this issue. Please DM me on TG @highoak86

katspaugh commented 10 months ago

I confirm it's really Alon from Redefine 👆 😄

omykhailovskyi commented 10 months ago

Hey, @highoak Thanks, it's verified now.

omykhailovskyi commented 10 months ago

Hey, @katspaugh Can you provide me your Telegram ID, want to discuss the risk related to lack of owners

katspaugh commented 10 months ago

The owners warning is a small risk, so not a blocker. Please consider adding more owners though. I'll go ahead and enable the app now.

Update:

The app is live now: https://app.safe.global/share/safe-app?appUrl=https%3A%2F%2Fsafe-eth.everstake.one%2F&chain=eth

Please note that unfortunately we don't support two icons (black and white), so I've added only the black one. It blends with the background in the dark mode, so ideally please provide an icon with its own background. Cheers!

omykhailovskyi commented 10 months ago

Hey, @katspaugh Thank you very much. Would you be able to replace the logo? Seems it's not how it looks like for custom app. The link is https://safe-eth.everstake.one/icon.svg. Sorry for disturbing you.

katspaugh commented 10 months ago

No worries, I've updated the icon.

Thank you for creating the app and your patience! 💚

omykhailovskyi commented 10 months ago

Thank you very much! Really appreciate it.

safe-global / safe-apps-list