Closed kamilmamin closed 2 months ago
This one is approved by the product team.
Hi @liliya-soroka, thank you for the review!
thank you for the details. We will remove Sepolia from the supported networks in the description to not enable prod app on Sepolia
cc @katspaugh , could you remove Sepolia from supported networks, to not enable the app their
Given point 3 in @kamilmamin I'd assume that the following issue is also expected to happen: If the safe doesn't have enought ETH to performe a tx it will show an error that the wallet doesn't have enough balance to perform the transaction, even tho for safes as long as the owner has enough tokens, the transaction CAN be executed.
Hi @francovenica, thank you for highlighting this use case, but this is not a problem for us, since the main account is used not only to pay for the transaction, but also to pay the service fee. Thus, we would like users to have sufficient available balance in their Safe account.
Just to clarify, in our system is not the Safe the one that pays for the tx and fees, is the owner that execute the tx. This means that a safe could have 0 ETH and still execute tx (like an adding an extra owner for example)
In this particular case, the safe had USDT in their assets, but didn't have ETH, that's why the error message. Now, the owner did have enough ETH to pay for the tx if he wanted to execute it
@francovenica I think what they're saying is that the app takes fees in Eth on top of the usual gas fees. So a Safe Account must have Eth to use this app.
Hi @francovenica and @katspaugh, thank you for your messages. In the future we plan to test other business models (including subscription), so we need a sufficient available balance in the Safe account. So I would leave everything as is if it's ok.
Note in case you got a notification about a comment: I deleted that comment I made since I found an issue that I thought it was related to this app but it wasn't the case. Apologies
Looks like it's ready to merge. Shall we @katspaugh ?
@francovenica all good from your side?
Yeah, looks good to me
Entry type
App info
URL: https://tezoro.io/ Name: Tezoro Description: Create a Digital Will - a smart contract that can transfer your assets to beneficiaries if something goes wrong.
Icon (PNG, 180x180):
Homepage: https://tezoro.io/ Twitter: https://twitter.com/tezoroio
App supports batching multiple transactions via Safe: No
Supported networks
Revision checks
manifest.json
file at the root with the required data – please paste the link to manifest.json here – apps without a manifset WILL NOT be accepted.Audit document
https://drive.google.com/drive/u/3/folders/1Po46EDwyCrIduWDO8pJqJZ_rYkkzv2IT
Code for review
GitLab (private repository - please request access): 1) https://gitlab.com/tezoro/tezoro-frontend-2.0 2) https://gitlab.com/tezoro/tezoro-backend Smart Contract: https://etherscan.io/address/0xcc48521161f55d937bb5204a7b5c3a9422e28a0a
Team information
Company: Tezoro, Inc.
Official website: https://tezoro.io/
Point of contact: Kamil Mamin, CEO
Email/Telegram: hello@tezoro.io