Add Hyperdrive Trading App

cashd commented 3 months ago

Entry type

New addition

App info

URL: https://app.hyperdrive.box/

Name: Hyperdrive One

Description: Get yield, your way. Access fixed and variable yields at your control with Hyperdrive.

Icon (PNG, 180x180): hyperdrive-logo-white-black 2

Homepage: Twitter: https://twitter.com/delv_tech GitHub: https://github.com/delvtech Discord: https://discord.com/invite/EEfKmfQdtx

App supports batching multiple transactions via Safe: yes/no

Supported networks

- Mainnet
- Gnosis Chain
- Base

Revision checks

[x] Used smart contracts were audited.
[x] You have implemented the app using the Safe Apps SDK
[x] Your Safe App includes a manifest.json file at the root with the required data – please paste the link to manifest.json here – apps without a manifset WILL NOT be accepted.
[x] The app can be loaded as a custom Safe App in the Apps section of https://app.safe.global.
[x] The app auto-connects to the Safe as a wallet
[x] It doesn't try to connect to the browser wallet (e.g. MetaMask)
[x] You are able to trigger and execute one transaction with a Safe.
[x] RPC requests are optimized (not triggering many requests in a very short time period).

Audit document

https://docs.hyperdrive.box/security/security-for-the-hyperdrive-protocol

Code for review

https://github.com/delvtech/hyperdrive-frontend/tree/main/apps/hyperdrive-trading

Team information

Company: DELV

Official website: https://delv.tech/

Point of contact: Charles St. Louis

Email/Telegram: charles@delv.tech

kirkkonen commented 3 months ago

This one was approved by the product team.

katspaugh commented 2 months ago

@cashd I don't see the icon. Is it white on white?

cashd commented 2 months ago

@cashd I don't see the icon. Is it white on white?

Yes it is, I went ahead and change it to white on black instead of a transparent background. Good catch thank you!

francovenica commented 2 months ago

Is said in the description that the app supports Sepolia, but I get a "wrong network" if I try the URL also given in the description. Is there another URL for sepolia?

katspaugh commented 2 months ago

@cashd are your contracts verified on etherscan?

CPSTL commented 2 months ago

Is said in the description that the app supports Sepolia, but I get a "wrong network" if I try the URL also given in the description. Is there another URL for sepolia?

Yes - the Testnet is hosted at https://testnet.hyperdrive.box/

cashd commented 2 months ago

@cashd are your contracts verified on etherscan?

All contracts on mainnet are verified, although not all sepolia contracts are. The app linked only supports production deployments so I will edit the supported chain list.

katspaugh commented 1 month ago

@francovenica do I get it right that this app has been tested and you approved it?

francovenica commented 1 month ago

@katspaugh No, I'll move the ticket back

The bridge seems not to be compatible with the safe. You cannot choose the safe as the source of the tokens being bridged:

cashd commented 1 month ago

@katspaugh No, I'll move the ticket back

The bridge seems not to be compatible with the safe. You cannot choose the safe as the source of the tokens being bridged:

This bridge is facilitated via SquidRouter and we use their components to support cross-chain bridging in app. Would this be a blocker? If so, we can remove this page from being visible if the dapp connector is safe.

francovenica commented 1 month ago

I have no objections with hiding it

@katspaugh what about you?

CPSTL commented 1 month ago

How are we looking in terms of getting this merged now? Thanks :) @katspaugh @francovenica

katspaugh commented 1 month ago

Let us know when the bridge is hidden, then @francovenica will test it one last time.

cashd commented 1 month ago

Hey @katspaugh @francovenica! We decided to remove the inline bridge functionality altogether so we should be good now. Let me know if anything else needs to be done.

francovenica commented 3 weeks ago

Hi there. sorry for taking so long. Yeah, without the bridge we are good.

LGTM

cashd commented 2 weeks ago

Hey! Just checking in to see if there is any remaining tasks on our end 🙏

iamacook commented 5 days ago

@cashd, apologies for the late response. The Safe App has now been listed.

Can you please confirm that everything is as expected, and whether it supports transaction batching?

cashd commented 1 day ago

@cashd, apologies for the late response. The Safe App has now been listed.

Can you please confirm that everything is as expected, and whether it supports transaction batching?

Thanks and everything works as expected but we don't support transaction batching. Throughout this process we renamed this app and deployed on Base and Gnosis Chain. I just updated this in the description. Could we get this updated please?

cashd commented 1 day ago

App Name: Hyperdrive Trading -> Hyperdrive One Supported Chains: Mainnet -> Mainnet, Gnosis, Base

iamacook commented 1 day ago

@cashd, I've updated the name and supported chains. Can you please confirm whether the App supports batching?

cashd commented 1 day ago

@cashd, I've updated the name and supported chains. Can you please confirm whether the App supports batching?

Thanks! Yes, I just confirmed transaction batching worked.

safe-global / safe-apps-list