Gimme.mom - Githubissues

safe-global / safe-apps-list

MIT License

20 stars 31 forks source link

Gimme.mom #388

Open Majorfi opened 3 months ago

Majorfi commented 3 months ago

Entry type

New addition

App info

URL: gimme.mom

Manifest.json URL: https://gimme.mom/manifest.json

Name: Gimme

Description: A very simple and UX focused way to deposit tokens to earn Yield on them. Built on Yearn's vault

Icon (PNG, 180x180): https://gimme.mom/favicons/apple-icon-180x180.png It's minified via https://tinypng.com: no

Homepage: https://gimme.mom Twitter: https://twitter.com/built_by_mom GitHub: https://github.com/BuiltByMom/gimme Discord: N/A

App supports batching multiple transactions via Safe: yes

Supported networks

- Polygon
- _We expect to release a multichain version in the next two weeks_

Revision checks

[X] Used smart contracts were audited.
[X] You have implemented the app using the Safe Apps SDK
[X] Your Safe App includes a manifest.json file at the root with the required data
[X] The app can be loaded as a custom Safe App in the Apps section of https://app.safe.global.
[X] The app auto-connects to the Safe as a wallet
[X] It doesn't try to connect to the browser wallet (e.g. MetaMask)
[X] You are able to trigger and execute one transaction with a Safe.
[X] RPC requests are optimized (not triggering many requests in a very short time period).

Audit document

https://docs.yearn.finance/security/#third-party-audits

Code for review

https://github.com/BuiltByMom/gimme

Team information

Company: MOM Official website: N/A Point of contact: Major / Facu Email/Telegram: @Majorfi / @saltyfacu

kirkkonen commented 2 months ago

This one was reviewed and approved by the product team.

PS: @Majorfi you didn't get back to me in the email so found this issue just now.

Majorfi commented 2 months ago

Oh my bad, sorry about that and thank you for the review!

francovenica commented 1 month ago

I'm getting this error in the dev console, which makes the button at the bottom load forever

I get the same error using your app as a stand alone in https://gimme.mom/earn, connecting my safe or my MM chrome extension.

Let us know if you are experiencing issues in your app currently

Majorfi commented 1 month ago

Hey, thank you for the finding! This has been fixed!

francovenica commented 4 days ago

Hi there, sorry for taking so long to check this.

It does work fine now. Thanks!

liliya-soroka commented 2 days ago

@parius the app is approved from the QA side