Add KyberSwap dApp

[tienkane]

Entry type

• New addition

App info

URL: https://kyberswap.com/

Name: KyberSwap

Description: KyberSwap is a multi-chain aggregator and DeFi hub that empowers users with the insights and tools to achieve financial autonomy. All the above while being fast, secure, and easy-to-use.

Icon (PNG, 180x180):

Homepage: https://kyberswap.com/ Twitter: https://x.com/kybernetwork GitHub: https://github.com/KyberNetwork Discord: https://discord.gg/kyberswap

App supports batching multiple transactions via Safe: yes

Supported networks

- Ethereum
- Arbitrum
- Optimism
- zkSync Era
- Polygon PoS
- Base
- BNB Chain
- Linea
- Mantle
- Scroll
- Avalanche
- Fantom
- Blast
- X Layer
- Polygon zkEVM
- Cronos
- BitTorrent

Revision checks

• [x] Used smart contracts were audited.
• [x] You have implemented the app using the Safe Apps SDK
• [x] Your Safe App includes a manifest.json file at the root with the required data – please paste the link to manifest.json here – apps without a manifset WILL NOT be accepted. (https://github.com/KyberNetwork/kyberswap-interface/blob/main/public/manifest.json)
• [x] The app can be loaded as a custom Safe App in the Apps section of https://app.safe.global.
• [x] The app auto-connects to the Safe as a wallet
• [x] It doesn't try to connect to the browser wallet (e.g. MetaMask)
• [x] You are able to trigger and execute one transaction with a Safe.
• [x] RPC requests are optimized (not triggering many requests in a very short time period).

Audit document

https://docs.kyberswap.com/security/audits

Code for review

https://github.com/KyberNetwork/kyberswap-interface

Team information

Company: Kyber Network

Official website: https://kyber.network/

Point of contact: Hugo

Email/Telegram: hugo@kyber.network

[kirkkonen]

This submission was checked and approved by the Product!

[francovenica]

Tried to add this app as a custom one but I get an error. Another URL of the app that I could try?

I tried "https://kyberswap.com/swap/zksync", "https://kyberswap.com/swap/", "https://kyberswap.com/" and none of those work. Tried in other networks as well.

[tienkane]

Hi @francovenica sorry for the late reply, I have fixed it, please check again with https://kyberswap.com/

[liliya-soroka]

Hi @tienkane , thank you for the fix. We have one comment related to the cross-chain swap: As the safe can not be replayed on all networks, we don't allow the cross-chain swap without the possibility of adding a different recipient on another network. Please disable the cross-chain swap for the safe app or add a recipient field.

[tienkane]

Hi @liliya-soroka, thank you for your feedback. I will consult with the Product team to assess the feasibility of your suggestion and provide a detailed response as soon as possible.

[tienkane]

Hi @liliya-soroka, We've already hidden the cross-chain swap section for the safe app. Please check. Thank you!

[liliya-soroka]

The state of the tx in n/m safes ( n>1) is not updated even after execution on-chain. As a result , the users are blocked and can not continue swap after the approve

cc @katspaugh

[katspaugh]

@tienkane the Safe Apps SDK/provider returns a safeTxHash when submitting a Safe transaction. You can use this hash to get the transaction's status.

It's different from regular wallets where you get an actual tx hash immediately, since Safe txs first go to our queue and have to be signed and subsequently executed.

[tienkane]

@liliya-soroka @katspaugh Thank you for your support in addressing this issue. I will implement the necessary changes and keep you updated on the progress