search

safe-global / safe-apps-list

MIT License
20 stars 31 forks source link

Update Sablier to v1.1.0 (BSC and Polygon deployment) #89

Closed PaulRBerg closed 2 years ago

PaulRBerg commented 3 years ago

Name/Description

Sablier. We recently deployed the protocol to BSC and Polygon. This update adds support for those two networks in our Gnosis Safe App. In addition, we listed four new tokens on Ethereum Mainnet:

And four new tokens on Polygon (beside the ~10 most popular tokens there):

Type

Compatible Networks

Code for review

https://github.com/paulrberg/sablier-safe-app/releases/tag/v1.1.1

IPFS hash/App URL

https://ipfs.infura.io/ipfs/QmeXrUW8fQE45GufCvseBtFmJjwrEzxjzNgEL1SSy8hx5Z/

Desired date

As soon as possible. We have already made the announcement that we are now on BSC and Polygon.

PaulRBerg commented 2 years ago

Hey guys, sorry to follow up (I don't like doing this). Our users are eager to start streaming on Polygon, via Gnosis Safe. Specifically mStable has followed up asking how long the listing on Polygon will take.

Any chance you could review this soon? :)

mmv08 commented 2 years ago

@paulrberg hey Paul, we got a few new members in the team, and we kept this ticket for them so they can get familiar with app testing/listing processes. I've asked them to prioritize this tomorrow. Sorry for the delay

PaulRBerg commented 2 years ago

Thanks a lot @mikheevm.

dasanra commented 2 years ago

@paulrberg we checked your app but we are having troubles with it. We are missing OLY and VODRA tokens on mainet, at least on the IPFS version that you provided.

Also we weren't able to use Polygon version, as we tried to test with DAI and USDC but balances aren't detected. As they are not using the same smart contract addresses on Polygon could this be the issue? If this is the case I suspect that this could also affect BSC

Could you take a look to this?

Thank you!

PaulRBerg commented 2 years ago

Hi @dasanra, thanks for double-checking. Not sure why it didn't work. I will look into this now .

PaulRBerg commented 2 years ago

We are missing OLY and VODRA tokens on mainet, at least on the IPFS version that you provided.

Actually, that is okay. I have mistakenly mentioned them - they were meant to only be listed on pay.sablier.finance.

we weren't able to use Polygon version, as we tried to test with DAI and USDC but balances aren't detected.

Yes, there was a bug in the code that generated the Infura URL. I forgot to append the API key 😬. I fixed this in this commit and included in the v1.1.1 release. The latest IPFS hash is QmeXrUW8fQE45GufCvseBtFmJjwrEzxjzNgEL1SSy8hx5Z. Finally, I updated the original issue to reference v1.1.1 instead of v1.1.0.

Sorry for the hassle.

dasanra commented 2 years ago

@paulrberg Perfect, don't worry, we always do a small check, is better if we catch this kind of things before publishing.

We already added it to production