safe-global / safe-apps-sdk

Client-side SDKs to create third-party Safe Apps
https://safe.global
MIT License
259 stars 117 forks source link

Support web3Modal v2.0.0 #431

Open franm91 opened 1 year ago

franm91 commented 1 year ago

Problem

Tried to use @gnosis.pm/safe-apps-web3modal but it does not support web3Modal v2.0.0 The current package support until "web3modal": "^1.9.9"

Feature

update @gnosis.pm/safe-apps-web3modal package to support the new version of web3Modal @web3modal/react.

bannik commented 1 year ago

I have created the following pr, which makes it possible to add SafeConnector to your web3modal alongside your modalConnectors: #441

Feel free to try it locally.

hughlaw commented 1 year ago

WalletConnect V1 official shuts down in 2 weeks...

Is there any movement on this wrapper to move to use a v2+ version of Web3Modal?

https://medium.com/walletconnect/t-1-month-last-call-to-migrate-before-the-walletconnect-v1-0-shutdown-692ffa9520aa

mmv08 commented 1 year ago

web3modal v2 uses wagmi and wagmi has a safe app connector, we're keeping this ticket open to update the docs