search

safe-global / safe-apps-sdk

Client-side SDKs to create third-party Safe Apps
https://safe.global
MIT License
250 stars 117 forks source link

Feature: add `sideEffects` property to package.json to improve tree-shaking #501

Closed mmv08 closed 1 year ago

mmv08 commented 1 year ago

This PR:

From the issue:

Without "sideEffects" switched off (e.g. "sideEffects": false) build systems aren't able to properly eliminate dead code (e.g. Next.js) and could still load these packages even if they are not used.

More info: https://webpack.js.org/guides/tree-shaking/#mark-the-file-as-side-effect-free

changeset-bot[bot] commented 1 year ago

🦋 Changeset detected

Latest commit: b2a674414802c7ae21768d51a68156d30d608d8b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 5 packages | Name | Type | | -------------------------------- | ----- | | @safe-global/safe-apps-react-sdk | Minor | | @safe-global/safe-apps-provider | Minor | | @safe-global/safe-apps-sdk | Minor | | @safe-global/safe-apps-web3modal | Major | | example-safe-apps-wagmi-cra | Patch |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR