search

safe-global / safe-apps-sdk

Client-side SDKs to create third-party Safe Apps
https://safe.global
MIT License
239 stars 114 forks source link

Can not add localhost as custom Safe App anymore. #558

Closed einaralex closed 3 months ago

einaralex commented 3 months ago

While testing out my Safe App, I used to be able to add localhost as a custom app. Now I get an error "The app doesn't support Safe App functionality."

I've recently changed browsers, so I re-visited Chrome and found that my localhost custom app is still cached there and still works there. But if I open up an incognito window and try to add it, I also get "The app doesn't support Safe App functionality."

Dev console says The FetchEvent for "http://localhost:3000/manifest.json" resulted in a network error response: the promise was resolved with an error response object., but it's there if I visit the url and it's the same manifest.json we use for our production app.

dasanra commented 3 months ago

Could you confirm that you configured CORS correctly for the app? For me it's possible to access an app via localhost https://github.com/safe-global/safe-apps-sdk/tree/main/packages/safe-apps-sdk#cors

einaralex commented 3 months ago

Thank you, I'll look into it, I suspect it might just be settings in Brave also.