Update EIP-5792 support, fixing pending status - Githubissues

safe-global / safe-apps-sdk

Client-side SDKs to create third-party Safe Apps

https://safe.global

MIT License

263 stars 125 forks source link

Update EIP-5792 support, fixing pending status #615

Open iamacook opened 2 days ago

iamacook commented 2 days ago

Summary

The EIP-5792 spec. has been adjusted, and it is not possible to get the PENDING status for a transaction that is queued off-chain.

This updates the implementation according to the current spec.:

Changing success to status
Adds chainId
Removes blockTimestamp

Should a transaction not have a txHash, ergo being queued, it returns a PENDING status for it.

Changes

Change success to status
Add chainId
Remove blockTimestamp
Return PENDING status for queued transactions

changeset-bot[bot] commented 2 days ago

🦋 Changeset detected

Latest commit: 30ec4d5f305af03da69992fb76bc9e914f4f4ed9

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

| Name | Type | | ------------------------------- | ----- | | @safe-global/safe-apps-provider | Patch |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR