search

safe-global / safe-cli

Command line utility for Safe
MIT License
208 stars 68 forks source link

Fix threshold retrieve in tx-service mode #410

Closed moisses89 closed 3 months ago

moisses89 commented 3 months ago

Description

When the safe-cli is running on ts-service mode the threshold was wrongly updated to the new value during a change_threshold command call. The issue was that the function prepare_and_execute_transaction is overwritten by the SafeTxOperator class with the difference that instead execute the transaction in blockchain, the overwritten function POST the transaction to the Safe Transaction Service without execute it.

Proposal solution

Update from blockchain the threshold value.

Related issue

Closes #323

coveralls commented 3 months ago

Coverage Status

coverage: 87.036% (-0.1%) from 87.16% when pulling efa6f28ab5535fecca8e268735b0548513ab96f8 on fix_reload_threeshold into cc5b9f1c080a2e7bbaca831bd41b699c89f946f3 on main.

coveralls commented 3 months ago

Coverage Status

coverage: 87.011% (-0.1%) from 87.136% when pulling 70133fba568b949c3e5d14dc6895f000dfb6514e on fix_reload_threeshold into 29be0a254631763e4c1ba79818507608eb4beafe on main.

coveralls commented 3 months ago

Coverage Status

coverage: 86.934% (-0.1%) from 87.033% when pulling 6ba56709b1b7a186e18332daa75fb32717c50a14 on fix_reload_threeshold into bebbba29662049863a52c2d4aed0163acee9fd70 on main.