safe-global / safe-cli

Command line utility for Safe

MIT License

208 stars 68 forks source link

Add message confirmation #418

Closed moisses89 closed 2 months ago

moisses89 commented 2 months ago

Description

Adds confirm_message for tx-service mode. This new command let the user add confirmation for a created message in the transaction service.

Closes #346

Other changes

sign_message for EIP191 is receiving now the message to sign as input instead of parameter, previous implementation had issues with quotes and blank spaces, also this new approach let the user paste longer messages.
refactor submit signatures to reuse the function sign_transaction, cleaning at this way duplicated code.

coveralls commented 2 months ago

coverage: 86.772% (-0.2%) from 86.934% when pulling 949e84f52f12f0d5a48ec326473ac3f291d5e33c on add_message_confirmation into 88ca9172447d9824a926cc031463129248b9c7ff on main.

coveralls commented 2 months ago

coverage: 87.279% (+0.3%) from 86.934% when pulling e1c6100eda61de7d6178678d231cfa1fbdeadcc3 on add_message_confirmation into 88ca9172447d9824a926cc031463129248b9c7ff on main.

coveralls commented 2 months ago

coverage: 87.279% (+0.3%) from 86.934% when pulling 53e6bffefa6811bdcbf49f5a175cf9293c107ac8 on add_message_confirmation into 88ca9172447d9824a926cc031463129248b9c7ff on main.

coveralls commented 2 months ago

coverage: 87.279% (+0.3%) from 86.934% when pulling b8b048e40a0e030de645df1c8e92c93bb885077d on add_message_confirmation into 88ca9172447d9824a926cc031463129248b9c7ff on main.

coveralls commented 2 months ago

coverage: 87.279% (+0.3%) from 86.934% when pulling 734f8d57ed627d676447474761d0ed82346b3ccb on add_message_confirmation into 88ca9172447d9824a926cc031463129248b9c7ff on main.

coveralls commented 2 months ago

coverage: 87.279% (+0.3%) from 86.934% when pulling 64bcea13967ef622673dbeecc4a4f8ff94ac7776 on add_message_confirmation into 88ca9172447d9824a926cc031463129248b9c7ff on main.

coveralls commented 2 months ago

coverage: 87.279% (+0.3%) from 86.934% when pulling 0e4d42639dcfb89585fc2cd1f1c2097ab1ac60ca on add_message_confirmation into 88ca9172447d9824a926cc031463129248b9c7ff on main.