safe-global / safe-cli

Command line utility for Safe

MIT License

208 stars 68 forks source link

Add hw wallet sign message #420

Closed moisses89 closed 2 months ago

moisses89 commented 2 months ago

Description

Add support to sign messages using hardware wallet on transaction service mode. Close #354

Other changes

sign_message just sign with the first provided owner because Safe Transaction Service is not accepting more than one signature to create the message. https://github.com/safe-global/safe-transaction-service/blob/49c65ec7187a20e06f466ecaeccbc601e8e0f547/safe_transaction_service/safe_messages/serializers.py#L34

coveralls commented 2 months ago

coverage: 87.131% (+0.2%) from 86.934% when pulling 66707301ef261b0ae5faf5f755971cd3e74b9bf3 on add_hw_wallet_sign_message into 88ca9172447d9824a926cc031463129248b9c7ff on main.

coveralls commented 2 months ago

coverage: 87.559% (+0.09%) from 87.47% when pulling 3bcfc8f30646a096bab492b917bed45366599f69 on add_hw_wallet_sign_message into ddd66d66093ddebbe1a9301319e1b8121d21a81d on main.

coveralls commented 2 months ago

coverage: 87.559% (+0.09%) from 87.47% when pulling 909e0f1709d6cbd919a72fd1c8a4892d43e71f4e on add_hw_wallet_sign_message into ddd66d66093ddebbe1a9301319e1b8121d21a81d on main.

coveralls commented 2 months ago

coverage: 88.571% (+0.07%) from 88.505% when pulling a12b5e1901473f8c7dae9cbf8b64999e88aeed2d on add_hw_wallet_sign_message into e829cd6e3cee124f2ab198049abed9e4e136035f on main.